Fix OPcache memory protection race under ZTS - #23081
Merged
arnaud-lb merged 3 commits intoAug 14, 2026
Merged
Conversation
realFlowControl
marked this pull request as ready for review
August 6, 2026 12:35
Contributor
Author
|
Also see: |
Contributor
Author
|
@arnaud-lb could you have a look at this PR? |
arnaud-lb
approved these changes
Aug 7, 2026
arnaud-lb
left a comment
Member
There was a problem hiding this comment.
This looks good to me, but it's unfortunate that we have to do this.
In master we could try to switch to a thread-specific memory protection mechanism. Since it's only for CI and debugging it would be fine if the mechanism is not universally available (the goal would be simplification, so no need for an mprotect fallback). We could use PKEYs on Linux and maybe pthread_jit_write_protect_np() on MacOS if that's not reserved for W^X use-cases. This would likely accelerate CI, too.
Contributor
Author
|
@arnaud-lb I fixed all the nested indentions in 1943fbb |
arnaud-lb
added a commit
that referenced
this pull request
Aug 14, 2026
* PHP-8.5: [ci skip] NEWS Fix OPcache memory protection race under ZTS (#23081)
Member
|
Thank you! |
pull Bot
pushed a commit
to Mattlk13/php-src
that referenced
this pull request
Aug 14, 2026
* PHP-8.4: [ci skip] NEWS Fix OPcache memory protection race under ZTS (php#23081)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this after adding tracing-JIT jobs to the
parallelCI, which so far only run function JIT. The new job reproducibly crashed while compiling a trace:The crash occurs because
opcache.protect_memorychanges shared-memory permissions process-wide, while ZTS threads manage the protection scopes independently.run-tests.phpsetsopcache.protect_memory=1, which is why this became visible in CI, default isopcache.protect_memory=0so most likely no one will actually see this crash in prod.The race is:
zend_shared_alloc_lock().SHM_UNPROTECT(), making OPcache shared memory writable.zend_shared_alloc_lock().SHM_UNPROTECT()followed bySHM_PROTECT().SIGSEGVorEXC_BAD_ACCESS.This PR makes unprotected sections nested and process-aware under ZTS:
The dedicated mutex is separate from
zend_shared_alloc_lock()because some callers already hold that lock when callingSHM_UNPROTECT().We do not see this in the
php-srcci in ZTS runs, because those are not running multiple threads, but everything is still single threaded.